Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra instance of list_view.hpp in meta.yaml. #10981

Merged
merged 1 commit into from
May 26, 2022
Merged

Remove extra instance of list_view.hpp in meta.yaml. #10981

merged 1 commit into from
May 26, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 26, 2022

A duplicate appears to have been added, perhaps during merge conflict resolution.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 26, 2022
@vyasr vyasr requested a review from a team as a code owner May 26, 2022 19:08
@vyasr vyasr self-assigned this May 26, 2022
@github-actions github-actions bot added the conda label May 26, 2022
@bdice bdice mentioned this pull request May 26, 2022
Merged
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #10981 (2435a30) into branch-22.06 (b4674a1) will not change coverage.
The diff coverage is n/a.

❗ Current head 2435a30 differs from pull request most recent head 49a8781. Consider uploading reports for the commit 49a8781 to get more accurate results

@@              Coverage Diff              @@
##           branch-22.06   #10981   +/-   ##
=============================================
  Coverage         86.33%   86.33%           
=============================================
  Files               144      144           
  Lines             22681    22681           
=============================================
  Hits              19581    19581           
  Misses             3100     3100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4674a1...49a8781. Read the comment docs.

@vyasr vyasr added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 26, 2022
msadang
msadang approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal looks good.

@msadang msadang merged commit fd5724f into rapidsai:branch-22.06 May 26, 2022
@bdice bdice mentioned this pull request May 27, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request May 31, 2022
@bdice
Sort recipe include checks. (#10984)
bb52477 
This PR sorts the recipe include checks in `meta.yaml`. Follows up on PR #10981 to try and reduce the likelihood of duplicates arising from accidental merge conflicts in the future.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Ray Douglass (https://github.com/raydouglass)

URL: #10984
@vyasr vyasr deleted the fix/remove_extra_file branch January 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msadang msadang msadang approved these changes

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @msadang