Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doxygen warnings in utilities/ headers #10974

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Fix doxygen warnings in utilities/ headers #10974

merged 6 commits into from
Jun 3, 2022

Conversation

karthikeyann
Copy link
Contributor

Fixes parts of #9373
added missing documentation to fix doxygen warnings in multiple files cpp/include/cudf/utilities/
fixes 167 warnings

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels May 25, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner May 25, 2022 20:15
@karthikeyann karthikeyann self-assigned this May 25, 2022
@karthikeyann karthikeyann requested a review from davidwendt May 27, 2022 12:29
@karthikeyann karthikeyann requested a review from davidwendt May 27, 2022 23:58
@codecov
Copy link

codecov bot commented May 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@6025f2b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c8eff5c differs from pull request most recent head 0e2801f. Consider uploading reports for the commit 0e2801f to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #10974   +/-   ##
===============================================
  Coverage                ?   86.32%           
===============================================
  Files                   ?      144           
  Lines                   ?    22696           
  Branches                ?        0           
===============================================
  Hits                    ?    19592           
  Misses                  ?     3104           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6025f2b...0e2801f. Read the comment docs.

davidwendt
davidwendt requested changes May 31, 2022
View reviewed changes
cpp/include/cudf/utilities/span.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/span.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/utilities/span.hpp Outdated Show resolved Hide resolved
davidwendt
davidwendt reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karthikeyann karthikeyann requested a review from davidwendt June 1, 2022 12:42
@karthikeyann karthikeyann requested a review from davidwendt June 1, 2022 15:08
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fe9a4f8 into rapidsai:branch-22.08 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @rgsl888prabhu @davidwendt