Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix gcc_linux version pinning in dev environment #10943

Merged
merged 1 commit into from
May 24, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 23, 2022

As part of conda compiler migration #10275 we switched to 9.x, this PR removes 9.3 requirement and switches it 9.x. This is because the following error is seen some machines:

Encountered problems while solving.
Problem: package gcc_linux-64-9.3.0-h44160b2_26 requires gcc_impl_linux-64 9.3.0.*, but none of the providers can be installed

Upgrading to 9.4.0 on those machines works fine. CI too picks up 9.4.0, for ex: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build-arm64/CUDA=11.5/4654/consoleText, hence fixes the broken dev environments.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 23, 2022
@galipremsagar galipremsagar self-assigned this May 23, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner May 23, 2022 23:47
@github-actions github-actions bot added the conda label May 23, 2022
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes my local dev environment. Thanks @galipremsagar! 🚀

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 3 - Ready for Review Ready for review by team and removed 3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge labels May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #10943 (6a918fc) into branch-22.06 (54789ee) will increase coverage by 0.02%.
The diff coverage is 93.75%.

@@               Coverage Diff                @@
##           branch-22.06   #10943      +/-   ##
================================================
+ Coverage         86.30%   86.32%   +0.02%     
================================================
  Files               144      144              
  Lines             22665    22668       +3     
================================================
+ Hits              19560    19569       +9     
+ Misses             3105     3099       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <87.50%> (-0.13%) ⬇️
python/cudf/cudf/io/avro.py 78.57% <100.00%> (ø)
python/cudf/cudf/io/csv.py 91.80% <100.00%> (ø)
python/cudf/cudf/io/json.py 97.56% <100.00%> (ø)
python/cudf/cudf/io/orc.py 92.77% <100.00%> (ø)
python/cudf/cudf/io/parquet.py 90.83% <100.00%> (ø)
python/cudf/cudf/io/text.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b053618...6a918fc. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 24, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit da74744 into rapidsai:branch-22.06 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants