Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify append deprecation notice. #10930

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 23, 2022

This clarifies that the deprecated append method is replaced by a top-level function cudf.concat. This has caused some user confusion, because it's not just a name change (DataFrame.concat doesn't exist).

@bdice bdice requested review from a team as code owners May 23, 2022 18:41
@bdice bdice changed the base branch from branch-22.06 to branch-22.08 May 23, 2022 18:41
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 23, 2022
@bdice bdice removed request for a team, trxcllnt and PointKernel May 23, 2022 18:41
@bdice bdice self-assigned this May 23, 2022
@bdice bdice added doc Documentation non-breaking Non-breaking change labels May 23, 2022
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 23, 2022
@shwina
Copy link
Contributor

shwina commented May 23, 2022

Thanks @bdice! Could you please change this to target 22.06 instead?

@shwina shwina changed the base branch from branch-22.08 to branch-22.06 May 23, 2022 19:24
@shwina shwina changed the base branch from branch-22.06 to branch-22.08 May 23, 2022 19:24
@shwina shwina added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels May 23, 2022
@bdice bdice force-pushed the doc/clarify-append-deprecation branch from 95216e9 to 3be1983 Compare May 23, 2022 19:38
@bdice bdice changed the base branch from branch-22.08 to branch-22.06 May 23, 2022 19:38
@bdice bdice added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #10930 (3be1983) into branch-22.06 (54789ee) will increase coverage by 0.02%.
The diff coverage is 93.75%.

@@               Coverage Diff                @@
##           branch-22.06   #10930      +/-   ##
================================================
+ Coverage         86.30%   86.32%   +0.02%     
================================================
  Files               144      144              
  Lines             22665    22668       +3     
================================================
+ Hits              19560    19569       +9     
+ Misses             3105     3099       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <87.50%> (-0.13%) ⬇️
python/cudf/cudf/io/avro.py 78.57% <100.00%> (ø)
python/cudf/cudf/io/csv.py 91.80% <100.00%> (ø)
python/cudf/cudf/io/json.py 97.56% <100.00%> (ø)
python/cudf/cudf/io/orc.py 92.77% <100.00%> (ø)
python/cudf/cudf/io/parquet.py 90.83% <100.00%> (ø)
python/cudf/cudf/io/text.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5067cc7...3be1983. Read the comment docs.

@vyasr
Copy link
Contributor

vyasr commented May 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b053618 into rapidsai:branch-22.06 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants