Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove C style artifacts in cuIO #10886

Merged
merged 6 commits into from
May 19, 2022
Merged

Remove C style artifacts in cuIO #10886

merged 6 commits into from
May 19, 2022

Conversation

vuule
Copy link
Contributor

@vuule vuule commented May 18, 2022

Renames header files to ".hpp".
Removes unnecessary extern "C"s.

@vuule vuule added cuIO cuIO issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 18, 2022
@vuule vuule self-assigned this May 18, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #10886 (dc838d7) into branch-22.06 (dee435f) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head dc838d7 differs from pull request most recent head 40b079f. Consider uploading reports for the commit 40b079f to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10886      +/-   ##
================================================
+ Coverage         86.30%   86.33%   +0.02%     
================================================
  Files               144      144              
  Lines             22665    22665              
================================================
+ Hits              19561    19567       +6     
+ Misses             3104     3098       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 91.70% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee435f...40b079f. Read the comment docs.

@vuule vuule marked this pull request as ready for review May 18, 2022 21:59
@vuule vuule requested a review from a team as a code owner May 18, 2022 21:59
@vuule vuule requested review from robertmaynard and bdice May 18, 2022 21:59
ttnghia
ttnghia reviewed May 18, 2022
View reviewed changes
cpp/src/io/avro/avro_common.hpp
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, NVIDIA CORPORATION.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about changing copyright year just because of changing file name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright enforcement script will require this.

Copy link
Contributor Author

@vuule vuule May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script passed, looks like it's not required for renames?
Never mind, it's the opposite. It's up to the script, either way :)

bdice
bdice approved these changes May 18, 2022
View reviewed changes
cpp/src/io/orc/orc_field_writer.hpp Show resolved Hide resolved
cpp/src/io/orc/orc_gpu.hpp Show resolved Hide resolved
cpp/src/io/orc/reader_impl.cu Show resolved Hide resolved
@vuule
Copy link
Contributor Author

vuule commented May 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c9bc82e into rapidsai:branch-22.06 May 19, 2022
@vuule vuule deleted the cuio-not-c-code branch May 19, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @bdice @ttnghia