Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sliced_child to get_sliced_child. #10885

Merged
merged 1 commit into from
May 18, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 18, 2022

This PR renames the lists/structs device view method sliced_child to get_sliced_child. This resolves some inconsistent naming (structs_column_view::get_sliced_child vs. structs_column_device_view::sliced_child). Resolves #10666.

@bdice bdice self-assigned this May 18, 2022
@bdice bdice added the breaking Breaking change label May 18, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 18, 2022
@bdice bdice added code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function and removed libcudf Affects libcudf (C++/CUDA) code. labels May 18, 2022
@bdice bdice changed the title Rename sliced_child to get_sliced_child. Rename sliced_child to get_sliced_child. May 18, 2022
@bdice bdice marked this pull request as ready for review May 18, 2022 13:34
@bdice bdice requested a review from a team as a code owner May 18, 2022 13:34
@bdice bdice requested review from hyperbolic2346 and ttnghia May 18, 2022 13:34
@bdice
Copy link
Contributor Author

bdice commented May 18, 2022

cc: @davidwendt / #10881.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #10885 (b4f01f5) into branch-22.06 (6352b4e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10885      +/-   ##
================================================
+ Coverage         86.29%   86.33%   +0.03%     
================================================
  Files               144      144              
  Lines             22656    22665       +9     
================================================
+ Hits              19552    19567      +15     
+ Misses             3104     3098       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 85.71% <ø> (ø)
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.79% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/index.py 92.06% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/core/series.py 95.17% <ø> (ø)
python/cudf/cudf/core/column/string.py 88.78% <100.00%> (+0.12%) ⬆️
python/dask_cudf/dask_cudf/groupby.py 97.42% <100.00%> (+<0.01%) ⬆️
python/dask_cudf/dask_cudf/tests/test_groupby.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9d51b...b4f01f5. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented May 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 851418c into rapidsai:branch-22.06 May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename structs_column_view::get_sliced_child
3 participants