-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segmented_reduce on empty column with non-empty offsets #10876
Fix segmented_reduce on empty column with non-empty offsets #10876
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10876 +/- ##
================================================
+ Coverage 86.29% 86.33% +0.03%
================================================
Files 144 144
Lines 22656 22665 +9
================================================
+ Hits 19552 19567 +15
+ Misses 3104 3098 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I suppose we tried to be too "clever" with the early exit here and it bit us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with the original Spark query that triggered a failure and it now produces the correct results with this change. Thanks, @davidwendt!
@gpucibot merge |
Fixes
cudf::segmented_reduce
where the inputvalues
column is empty but theoffsets
are not. In this case, theoffsets
vector{0,0}
specifies an empty segment which should result in a single null row. The logic has been fixed and new gtest cases have been added.Closes #10556