Support for Zstandard decompression in ORC reader #10873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e04ac19.
Co-authored-by: Mike Wilson <[email protected]>
This reverts commit 7a7c7f8.
github-actions
bot
added
Python
vuule
added
feature request
github-actions
bot
added
Python
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10873 +/- ##
================================================
+ Coverage 86.30% 86.32% +0.02%
================================================
Files 144 144
Lines 22665 22668 +3
================================================
+ Hits 19560 19569 +9
+ Misses 3105 3099 -6
Continue to review full report at Codecov.
|
PointKernel
reviewed
May 19, 2022
hyperbolic2346
approved these changes
May 19, 2022
galipremsagar
approved these changes
May 19, 2022
vuule
commented
May 20, 2022
galipremsagar
approved these changes
May 20, 2022
|
rerun tests |
1 similar comment
|
rerun tests |
PointKernel
approved these changes
May 23, 2022
cpp/src/io/comp/uncomp.cpp
Outdated
|
|
||
| // Copy temporary output to `dst` | ||
| CUDF_CUDA_TRY( | ||
| cudaMemcpyAsync(dst.data(), d_dst.data(), dst.size(), cudaMemcpyDeviceToHost, stream.value())); |
There was a problem hiding this comment.
Suggested change
| cudaMemcpyAsync(dst.data(), d_dst.data(), dst.size(), cudaMemcpyDeviceToHost, stream.value())); | |
| cudaMemcpyAsync(dst.data(), d_dst.data(), max_uncomp_page_size, cudaMemcpyDeviceToHost, stream.value())); |
There was a problem hiding this comment.
just realized from this suggestion that we don't need to copy the whole buffer, just the portion that contains the actual output.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds decompressor API for host-to-host decompression for ORC footer decompression.
Test changes: