[DOC] spell check fixes #10865
[DOC] spell check fixes #10865
Conversation
karthikeyann
added
3 - Ready for Review
github-actions
bot
added
Python
There was a problem hiding this comment.
Thanks @karthikeyann ! Approving this PR but would like to see the falsy comment considered as it is a pythonic term.
Also, could the spell checker that you are using be enforced in CI?
| @@ -4506,7 +4506,7 @@ def from_pandas(cls, dataframe, nan_as_null=None): | |||
| Parameters | |||
| ---------- | |||
| dataframe : Pandas DataFrame object | |||
| A Pandads DataFrame object which has to be converted | |||
| @@ -2044,7 +2044,7 @@ def searchsorted( | |||
| na_position=na_position, | |||
| ) | |||
|
|
|||
| # Retrun result as cupy array if the values is non-scalar | |||
There was a problem hiding this comment.
return + run = retrun 🤣
python/cudf/cudf/core/reshape.py
Outdated
| @@ -395,7 +395,7 @@ def concat(objs, axis=0, join="outer", ignore_index=False, sort=None): | |||
| axis=axis, | |||
| join=join, | |||
| ignore_index=ignore_index, | |||
| # Explicitly cast rather than relying on None being falsy. | |||
There was a problem hiding this comment.
We probably can keep this falsy: https://stackoverflow.com/a/39984051
Can we add falsy to the spell checker vocab?
spell checker right now does not understand inline or example code and argument names right now. So there are 100s of words which are mostly argument names and function names used in code. So, if add these exceptions, vocabulary will contain mostly arguments and function names. It does not look like a clean solution to be in CI right now. This CI will most likely fail when we add any example with new argument names in the docstring. |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10865 +/- ##
================================================
+ Coverage 86.29% 86.32% +0.03%
================================================
Files 144 144
Lines 22656 22656
================================================
+ Hits 19551 19558 +7
+ Misses 3105 3098 -7
Continue to review full report at Codecov.
|
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
Ran spell check on comments on public facing APIs and fixed them.