Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing list_view.cuh to list_view.hpp #10854

Merged
merged 3 commits into from
May 16, 2022
Merged

Changing list_view.cuh to list_view.hpp #10854

merged 3 commits into from
May 16, 2022

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented May 13, 2022

This is a small refactor, changing list_view.cuh to list_view.hpp as this file only contains the definition of cudf::list_view which is an empty class and nothing else.

@ttnghia ttnghia added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 13, 2022
@ttnghia ttnghia self-assigned this May 13, 2022
@ttnghia ttnghia requested a review from a team as a code owner May 13, 2022 20:37
@ttnghia ttnghia requested review from harrism and nvdbaranec May 13, 2022 20:37
@codecov

This comment was marked as off-topic.

Sign in to view
karthikeyann
karthikeyann approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ttnghia
Copy link
Contributor Author

ttnghia commented May 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 42438de into rapidsai:branch-22.06 May 16, 2022
@ttnghia ttnghia deleted the rename_list_view_cuh branch May 17, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@vyasr vyasr vyasr approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttnghia @vyasr @karthikeyann