-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pre-built nvcomp 2.3 binaries by default #10851
Merged
rapids-bot
merged 25 commits into
rapidsai:branch-22.06
from
robertmaynard:fea/use_rapids_cpm_nvcomp
May 25, 2022
Merged
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
168af05
Add support for nvcomp-2.3 in java build
jbrennan333 f2f9ad9
Update copyrights.
jbrennan333 7f5d453
Use $<TARGET_FILE:nvcomp::nvcomp> to get the full path
jbrennan333 d8b8c89
Add COMMENT to custom command to fix checkstyle issue
jbrennan333 eb43115
Use pre-built nvcomp 2.3 binaries by default
robertmaynard a5b4761
fix style issues found by ci
robertmaynard c1e5275
Update java side to use nvcomp from cudf
robertmaynard ff46fd3
Merge branch 'branch-22.06' into jtb-nvcomp-2.3
jbrennan333 2e1b583
Merge commit 'jbrennan333:jtb-nvcomp-2.3' into fea/use_rapids_cpm_nvcomp
robertmaynard 085de05
Merge branch 'branch-22.06' into fea/use_rapids_cpm_nvcomp
robertmaynard d1ad96b
Correct style issues found by CI
robertmaynard f0667a8
Add build.sh option to control using proprietary nvcomp binaries
robertmaynard c64d4d9
Add conda license agreement
robertmaynard db7a437
Add conda license agreement
robertmaynard 0bb4bba
Update build.sh
robertmaynard cfd4e4b
Use rapids-cmake 22.06
robertmaynard 6ac5a9c
Fix style issues found by ci
robertmaynard 4537c95
Merge branch 'branch-22.06' into fea/use_rapids_cpm_nvcomp
robertmaynard 437ba41
Adding missing entry to meta.yml
robertmaynard 7f514bf
Adding missing entry to meta.yml
robertmaynard 0403c06
Fix style issues found by ci
robertmaynard 618d750
properly name nvcomp license file
robertmaynard f531c11
Apply suggestions from code review
vyasr 4827a64
Merge branch 'branch-22.06' into fea/use_rapids_cpm_nvcomp
robertmaynard 7758d88
Merge branch 'branch-22.06' into fea/use_rapids_cpm_nvcomp
robertmaynard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
By downloading and using the libcudf conda package, you accept the terms | ||
and conditions of the NVIDIA NVCOMP Software License Agreement: | ||
https://developer.download.nvidia.com/compute/nvcomp/2.3/LICENSE.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2022, NVIDIA CORPORATION. | ||
# Only add the license notice to libcudf and not our examples / tests | ||
if [[ "$PKG_NAME" == "libcudf" ]]; then | ||
cat ./nvlink.txt>> $PREFIX/.messages.txt | ||
vyasr marked this conversation as resolved.
Show resolved
Hide resolved
vyasr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it a bit disconcerting that all of the flags used for the JNI build do not respect the script's CLI. That seems like it's just waiting to bite some unsuspecting user of
build.sh
eventually. It looks like this isn't a new problem though since it affects all of the flags used in the JNI build, though, so we don't need to block this PR over this. It's probably worth factoring this build logic into a separate script thought since AFAICT it completely ignores all of the logic and variables in this build.sh script.