Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constness / references in weak ordering operator() signatures. #10846

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 13, 2022

Resolves issues raised in #10730 about operator() being const and accepting references. cc: @ttnghia @jrhemstad

I applied const noexcept across all operator()s in the experimental row comparators, to match the existing pattern.

@bdice bdice requested a review from a team as a code owner May 13, 2022 03:55
@bdice bdice requested review from mythrocks and ttnghia May 13, 2022 03:55
@bdice bdice self-assigned this May 13, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 13, 2022
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #10846 (3433ccc) into branch-22.06 (e0d94f3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 3433ccc differs from pull request most recent head 67ff2f5. Consider uploading reports for the commit 67ff2f5 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10846      +/-   ##
================================================
+ Coverage         86.28%   86.32%   +0.03%     
================================================
  Files               144      144              
  Lines             22654    22656       +2     
================================================
+ Hits              19548    19558      +10     
+ Misses             3106     3098       -8     
Impacted Files Coverage Δ
python/cudf/cudf/core/resample.py 88.97% <ø> (ø)
python/dask_cudf/dask_cudf/groupby.py 97.42% <100.00%> (+0.01%) ⬆️
python/dask_cudf/dask_cudf/tests/test_groupby.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/dask_cudf/dask_cudf/core.py 73.62% <0.00%> (+0.26%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad1e51...67ff2f5. Read the comment docs.

@jrhemstad
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 13c21d0 into rapidsai:branch-22.06 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants