Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doxygen warnings #10842

Merged
merged 7 commits into from
May 14, 2022
Merged

fix doxygen warnings #10842

merged 7 commits into from
May 14, 2022

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented May 12, 2022

This PR fixes 433 doxygen warnings.

As prerequisite for doxygen CI check #9373, the warnings from doxygen should be minimized as much as possible.
This is one of the series of PRs to fix doxygen documentation warnings.

@karthikeyann karthikeyann added 2 - In Progress Currently a work in progress doc Documentation code quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 12, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner May 12, 2022 18:57
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 12, 2022
@karthikeyann karthikeyann removed the improvement Improvement / enhancement to an existing function label May 12, 2022
@github-actions github-actions bot added the conda label May 13, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner May 13, 2022 04:26
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to open PRs from forks in the future. Not the source repository.

@github-actions github-actions bot added the gpuCI label May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #10842 (08ed165) into branch-22.06 (e0d94f3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 08ed165 differs from pull request most recent head 64b1dcf. Consider uploading reports for the commit 64b1dcf to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10842      +/-   ##
================================================
+ Coverage         86.28%   86.32%   +0.03%     
================================================
  Files               144      144              
  Lines             22654    22656       +2     
================================================
+ Hits              19548    19557       +9     
+ Misses             3106     3099       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/resample.py 88.97% <ø> (ø)
python/dask_cudf/dask_cudf/groupby.py 97.42% <100.00%> (+0.01%) ⬆️
python/dask_cudf/dask_cudf/tests/test_groupby.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/dask_cudf/dask_cudf/core.py 73.62% <0.00%> (+0.26%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 91.70% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d94f3...64b1dcf. Read the comment docs.

@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6591a6a into branch-22.06 May 14, 2022
@karthikeyann karthikeyann deleted the doc-fix_warnings3 branch May 14, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants