Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the JNI call for Cuda.deviceSynchronize #10839

Merged

Conversation

abellina
Copy link
Contributor

@abellina abellina commented May 12, 2022

Running tests locally, but putting this up as WIP for now.

Discussing with @jlowe a solution to NVIDIA/spark-rapids#4818 could involve cudaDeviceSynchronize. I noticed that's not in our JNI exposed calls, so I am adding it here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label May 12, 2022
@abellina abellina added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #10839 (06a72f1) into branch-22.06 (e0d94f3) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 06a72f1 differs from pull request most recent head 7b3dd82. Consider uploading reports for the commit 7b3dd82 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10839      +/-   ##
================================================
+ Coverage         86.28%   86.32%   +0.03%     
================================================
  Files               144      144              
  Lines             22654    22654              
================================================
+ Hits              19548    19555       +7     
+ Misses             3106     3099       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 91.70% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d94f3...7b3dd82. Read the comment docs.

@abellina abellina marked this pull request as ready for review May 12, 2022 18:15
@abellina abellina requested a review from a team as a code owner May 12, 2022 18:15
@abellina
Copy link
Contributor Author

ok I can use this locally. It looks to be good to go in, pending CI.

@abellina
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1bb3aac into rapidsai:branch-22.06 May 12, 2022
@abellina abellina deleted the jni/add_device_synchronize_call branch May 12, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants