Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup regex compile optimize functions #10825

Merged
merged 3 commits into from
May 12, 2022

Conversation

davidwendt
Copy link
Contributor

Cleans up the internal regcomp::optimize1() function by replacing for-loops with STL functions. Hopefully this will make this part of the code a bit easier to understand and maintain.

No external function or behavior has changed.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. tech debt strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 10, 2022
@davidwendt davidwendt self-assigned this May 10, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #10825 (ef17bb9) into branch-22.06 (8d861ce) will decrease coverage by 0.08%.
The diff coverage is 94.84%.

❗ Current head ef17bb9 differs from pull request most recent head 7982923. Consider uploading reports for the commit 7982923 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10825      +/-   ##
================================================
- Coverage         86.40%   86.31%   -0.09%     
================================================
  Files               143      144       +1     
  Lines             22448    22648     +200     
================================================
+ Hits              19396    19549     +153     
- Misses             3052     3099      +47     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.78% <ø> (-0.31%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/io/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/testing/testing.py 81.81% <50.00%> (+0.12%) ⬆️
python/cudf/cudf/io/parquet.py 90.83% <86.60%> (-1.87%) ⬇️
python/cudf/cudf/core/index.py 92.06% <88.88%> (-0.25%) ⬇️
python/cudf/cudf/core/scalar.py 89.01% <90.90%> (-0.31%) ⬇️
python/cudf/cudf/core/dataframe.py 93.78% <96.36%> (+0.08%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (+0.22%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd2c39...7982923. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 11, 2022
@davidwendt davidwendt marked this pull request as ready for review May 11, 2022 18:24
@davidwendt davidwendt requested a review from a team as a code owner May 11, 2022 18:24
@davidwendt davidwendt requested review from harrism and nvdbaranec May 11, 2022 18:24
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice modernization!

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fe9aaeb into rapidsai:branch-22.06 May 12, 2022
@davidwendt davidwendt deleted the regex-rework-optimizers branch May 12, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants