-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup regex compile optimize functions #10825
Cleanup regex compile optimize functions #10825
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10825 +/- ##
================================================
- Coverage 86.40% 86.31% -0.09%
================================================
Files 143 144 +1
Lines 22448 22648 +200
================================================
+ Hits 19396 19549 +153
- Misses 3052 3099 +47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice modernization!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gpucibot merge |
Cleans up the internal
regcomp::optimize1()
function by replacing for-loops with STL functions. Hopefully this will make this part of the code a bit easier to understand and maintain.No external function or behavior has changed.