-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor regex builtin character-class identifiers #10814
Refactor regex builtin character-class identifiers #10814
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10814 +/- ##
================================================
- Coverage 86.40% 86.30% -0.11%
================================================
Files 143 144 +1
Lines 22448 22629 +181
================================================
+ Hits 19396 19529 +133
- Misses 3052 3100 +48
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions attached. Otherwise LGTM!
@gpucibot merge |
Refactors the builtin regex class integer ids to common header for the compiler and executor.
The builtin regex character classes like
\s, \d, \W
have integer identifiers (bit values that can be combined) but were defined in separate source files. This PR refactors the declarations to the common header fileregcomp.h
to ensure the same value is used when parsing/compiling the instructions inregcomp.cpp
and when evaluating the instructions inregex.inl
.This is just a cleanup of the code and does not effect behavior or performance.