Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNI support for apply_boolean_mask #10812

Merged
merged 3 commits into from
May 12, 2022

Conversation

res-life
Copy link
Contributor

@res-life res-life commented May 7, 2022

Contributes to #10650

Add JNI support for apply_boolean_mask

Refer to the descriptions of PR #10773

Signed-off-by: Chong Gao [email protected]

@res-life res-life requested a review from a team as a code owner May 7, 2022 06:27
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions github-actions bot added the Java Affects Java cuDF API. label May 7, 2022
@firestarman firestarman added feature request New feature or request non-breaking Non-breaking change labels May 7, 2022
Signed-off-by: Chong Gao <[email protected]>
@firestarman
Copy link
Contributor

rerun tests

@ttnghia ttnghia added 3 - Ready for Review Ready for review by team Spark Functionality that helps Spark RAPIDS labels May 8, 2022
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const nits but otherwise lgtm.

java/src/main/native/src/ColumnViewJni.cpp Outdated Show resolved Hide resolved
@res-life
Copy link
Contributor Author

rerun tests

@res-life
Copy link
Contributor Author

@gpucibot merge

@res-life
Copy link
Contributor Author

ok to test

1 similar comment
@harrism
Copy link
Member

harrism commented May 11, 2022

ok to test

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #10812 (2a369fa) into branch-22.06 (4913a9b) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10812      +/-   ##
================================================
- Coverage         86.42%   86.31%   -0.12%     
================================================
  Files               143      144       +1     
  Lines             22493    22648     +155     
================================================
+ Hits              19440    19549     +109     
- Misses             3053     3099      +46     
Impacted Files Coverage Δ
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <0.00%> (-67.93%) ⬇️
python/cudf/cudf/io/parquet.py 90.83% <0.00%> (-1.87%) ⬇️
python/dask_cudf/dask_cudf/backends.py 85.51% <0.00%> (-0.94%) ⬇️
python/cudf/cudf/core/column/categorical.py 89.37% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.60% <0.00%> (-0.50%) ⬇️
python/cudf/cudf/core/column/lists.py 91.70% <0.00%> (-0.38%) ⬇️
python/cudf/cudf/core/scalar.py 89.01% <0.00%> (-0.31%) ⬇️
python/cudf/cudf/core/column/string.py 88.78% <0.00%> (-0.31%) ⬇️
python/cudf/cudf/core/index.py 92.06% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_s3.py 96.05% <0.00%> (-0.15%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4913a9b...2a369fa. Read the comment docs.

@res-life
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@harrism
Copy link
Member

harrism commented May 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e0d94f3 into rapidsai:branch-22.06 May 12, 2022
@res-life res-life deleted the apply-boolean-mask branch May 12, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants