Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NumPy to intersphinx references. #10809

Merged
merged 2 commits into from
May 6, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 6, 2022

This PR adds numpy to the list of intersphinx references, which is needed to cross-reference numpy functions in cuDF's documentation. The Python intersphinx reference was updated to resolve a warning caused by a redirect. This also fixes a reference to numpy.asarray, which is a function (not a method).

@bdice bdice added doc Documentation non-breaking Non-breaking change labels May 6, 2022
@bdice bdice self-assigned this May 6, 2022
@bdice bdice requested a review from a team as a code owner May 6, 2022 17:11
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #10809 (7b12fc7) into branch-22.06 (8d861ce) will increase coverage by 0.04%.
The diff coverage is 96.49%.

@@               Coverage Diff                @@
##           branch-22.06   #10809      +/-   ##
================================================
+ Coverage         86.40%   86.44%   +0.04%     
================================================
  Files               143      143              
  Lines             22448    22493      +45     
================================================
+ Hits              19396    19445      +49     
+ Misses             3052     3048       -4     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/core/dataframe.py 93.77% <96.29%> (+0.08%) ⬆️
python/cudf/cudf/testing/_utils.py 94.05% <100.00%> (+0.06%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0f7e0...7b12fc7. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 6, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4913a9b into rapidsai:branch-22.06 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants