Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the JNI API to get list offsets as a view public. #10807

Merged

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented May 6, 2022

This is an API I would like to use to help a customer with a UDF so I would like to make it public.

@revans2 revans2 added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2022
@revans2 revans2 requested a review from a team as a code owner May 6, 2022 14:36
@revans2 revans2 self-assigned this May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #10807 (71724af) into branch-22.06 (8d861ce) will increase coverage by 0.04%.
The diff coverage is 96.49%.

❗ Current head 71724af differs from pull request most recent head a456e49. Consider uploading reports for the commit a456e49 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10807      +/-   ##
================================================
+ Coverage         86.40%   86.45%   +0.04%     
================================================
  Files               143      143              
  Lines             22448    22493      +45     
================================================
+ Hits              19396    19446      +50     
+ Misses             3052     3047       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/core/dataframe.py 93.77% <96.29%> (+0.08%) ⬆️
python/cudf/cudf/testing/_utils.py 94.05% <100.00%> (+0.06%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0f7e0...a456e49. Read the comment docs.

@revans2
Copy link
Contributor Author

revans2 commented May 6, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a8f0976 into rapidsai:branch-22.06 May 6, 2022
@revans2 revans2 deleted the make_jni_column_offsets_visible branch May 6, 2022 17:18
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants