Fix element access const correctness in hostdevice_vector
#10804
Conversation
vuule
added
bug
| } | ||
| T const* end() const { return h_data + num_elements; } | ||
|
|
||
| auto d_begin() { return static_cast<T*>(d_data.data()); } |
There was a problem hiding this comment.
For clarity and consistency with the host accessors, should we use T*, T const*, etc. instead of auto? It's somewhat obvious from the static_cast in the return statement, so maybe not needed.
There was a problem hiding this comment.
Yeah, I justified it with the cast in each function (strictly speaking, naming the type twice breaks the DRY rule).
The real reason is that the last function breaks into multiple lines if I specify the return type :D
I don't have any good reasons to prefer one of the options here, let me know if you want to remove autos here.
There was a problem hiding this comment.
I approved the PR because I was fine with any outcome here. Just leave it as-is. 👍
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10804 +/- ##
================================================
+ Coverage 86.40% 86.45% +0.04%
================================================
Files 143 143
Lines 22448 22491 +43
================================================
+ Hits 19396 19444 +48
+ Misses 3052 3047 -5
Continue to review full report at Codecov.
|
|
@gpucibot merge |
hostdevice_vectormembers that are used for element access do not return const pointers/references when called on const objects.This PR makes sure all function members of
hostdevice_vectorare const correct: