simplifying skiprows test in test_orc.py #10783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperbolic2346
added
3 - Ready for Review
|
Too kind. 😉 Thanks for the PR! |
hyperbolic2346
added
code quality
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10783 +/- ##
================================================
+ Coverage 86.40% 86.45% +0.04%
================================================
Files 143 143
Lines 22448 22491 +43
================================================
+ Hits 19396 19444 +48
+ Misses 3052 3047 -5
Continue to review full report at Codecov.
|
galipremsagar
approved these changes
May 5, 2022
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bdice helped me look into an issue with deprecated warnings in #10772 and in the process, he pointed out that the skiprows test was unnecessarily complex. We looked into it some and it appeared to be a copy/paste of a more complex test. He asked that I make this PR to simplify this test, but all the credit for noticing and fixing it is his.