Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple rows to subword tokenizer benchmark #10767

Merged
merged 1 commit into from
May 3, 2022
Merged

Add multiple rows to subword tokenizer benchmark #10767

merged 1 commit into from
May 3, 2022

Conversation

davidwendt
Copy link
Contributor

When porting the subword tokenizer code from CLX, the benchmark was not updated to measure multiple rows. This updates the benchmark to include a row test range and add the missing cuda_event_timer.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 2, 2022
@davidwendt davidwendt self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022 •
edited
Loading

Codecov Report

Merging #10767 (54aceed) into branch-22.06 (027c34a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10767      +/-   ##
================================================
+ Coverage         86.40%   86.42%   +0.02%     
================================================
  Files               143      143              
  Lines             22444    22444              
================================================
+ Hits              19393    19398       +5     
+ Misses             3051     3046       -5
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 95.88% <0.00%> (-0.30%) ⬇️
python/cudf/cudf/core/dataframe.py 93.74% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6128e0d...54aceed. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 2, 2022
@davidwendt davidwendt marked this pull request as ready for review May 2, 2022 15:39
@davidwendt davidwendt requested a review from a team as a code owner May 2, 2022 15:39
@davidwendt davidwendt requested review from cwharris and codereport May 2, 2022 15:39
codereport
codereport approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

karthikeyann
karthikeyann reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
This PR could also be an opportunity to move from gbench to NVBench.

@davidwendt
Copy link
Contributor Author

Looks good. This PR could also be an opportunity to move from gbench to NVBench.

Yes, I considered that but I think I want to convert all of the text ones at the same time instead.

karthikeyann
karthikeyann approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0e32624 into rapidsai:branch-22.06 May 3, 2022
@davidwendt davidwendt deleted the subword-benchmark branch May 3, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @karthikeyann @codereport