Flush output streams before creating a process to drop caches #10762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
tests
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10762 +/- ##
================================================
+ Coverage 86.40% 86.43% +0.02%
================================================
Files 143 143
Lines 22444 22444
================================================
+ Hits 19393 19399 +6
+ Misses 3051 3045 -6
Continue to review full report at Codecov.
|
nvdbaranec
approved these changes
Apr 29, 2022
bdice
reviewed
Apr 29, 2022
cpp/benchmarks/io/cuio_common.cpp
Outdated
| @@ -145,6 +145,8 @@ std::vector<cudf::size_type> segments_in_chunk(int num_segments, int num_chunks, | |||
| // Executes the command and returns stderr output | |||
| std::string exec_cmd(std::string_view cmd) | |||
| { | |||
| // Prevent the output from the command from mixing with the original process' output | |||
| fflush(nullptr); | |||
There was a problem hiding this comment.
Is this std::fflush? Can we use the std:: prefix if so?
There was a problem hiding this comment.
May also need #include <cstdio> for completeness.
There was a problem hiding this comment.
Not sure if it was std::fflush, but now it is :)
Added the include too.
bdice
approved these changes
Apr 29, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement for the
try_drop_l3_cachefeature in cuIO benchmarks.Prevents unflushed output from the original process from intermingling with the output from the
popenprocess.