-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix construction of nested structs with EMPTY child #10761
Fix construction of nested structs with EMPTY child #10761
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10761 +/- ##
================================================
- Coverage 86.40% 86.32% -0.09%
================================================
Files 143 144 +1
Lines 22444 22656 +212
================================================
+ Hits 19393 19558 +165
- Misses 3051 3098 +47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I always assumed that EMPTY just means an invalid type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to test this? Perhaps the pytest is enough for this change.
This is an issue that exists independent of Python -- simply constructing a structs column or reading an Arrow array with the specified structure would fail prior to this PR. |
Co-authored-by: Bradley Dice <[email protected]>
rerun tests |
…na/cudf into fix-nested-struct-with-empty-column
@gpucibot merge |
This PR adds the ability to construct a structs columns with a parent null mask, but an EMPTY child. Prior to this PR, this would fail with a runtime error. This is because the parent null mask is superimposed on the EMPTY child, but EMPTY columns cannot contain null masks.
This PR also includes a small change in the Cython, where we map libcudf's
EMPTY
type to aint8
type on the Python side.