Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pydocstyle for all packages. #10759

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 29, 2022

Follow-up to #10748 to enable the base pydocstyle rules on all Python packages (dask_cudf, cudf_kafka, custreamz) and test files. Contributes to #10711, #10758.

@bdice bdice added doc Documentation Python Affects Python cuDF API. non-breaking Non-breaking change labels Apr 29, 2022
@bdice bdice self-assigned this Apr 29, 2022
@bdice bdice requested a review from a team as a code owner April 29, 2022 14:04
@bdice
Copy link
Contributor Author

bdice commented Apr 29, 2022

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #10759 (8ab68d5) into branch-22.06 (84f88ce) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10759      +/-   ##
================================================
+ Coverage         86.40%   86.43%   +0.02%     
================================================
  Files               143      143              
  Lines             22444    22444              
================================================
+ Hits              19393    19399       +6     
+ Misses             3051     3045       -6     
Impacted Files Coverage Δ
python/cudf/cudf/comm/gpuarrow.py 79.76% <ø> (ø)
python/cudf/cudf/core/column/string.py 89.21% <ø> (+0.12%) ⬆️
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/series.py 95.16% <ø> (ø)
python/custreamz/custreamz/kafka.py 29.16% <ø> (ø)
python/cudf/cudf/core/dataframe.py 93.74% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c208a6...8ab68d5. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 15e4982 into rapidsai:branch-22.06 Apr 29, 2022
@bdice bdice deleted the enable-pydocstyle-all-packages branch April 29, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants