-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generator expressions in any/all functions. #10736
Conversation
rerun tests |
1 similar comment
rerun tests |
Co-authored-by: Vyas Ramasubramani <[email protected]>
This reverts commit cd641e3.
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10736 +/- ##
================================================
+ Coverage 86.40% 86.43% +0.02%
================================================
Files 143 143
Lines 22444 22444
================================================
+ Hits 19393 19399 +6
+ Misses 3051 3045 -6
Continue to review full report at Codecov.
|
@gpucibot merge |
This PR uses generator expressions in
any(...)
andall(...)
to avoid allocating a list in memory while maximizing the potential benefit of early exit from theany
/all
function.I also fixed a few miscellaneous things (~ 10 lines):
cls
inclassmethod
ssuper()
with no arguments if the arguments are the parent class andself
Note: Some of these were caught by https://codereview.doctor/rapidsai/cudf. In some places, the bot correctly identified a problem but its suggestions were invalid or incomplete. I identified steps for improvement beyond what the bot suggested for most of these cases.