Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured bindings instead of std::tie #10726

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

karthikeyann
Copy link
Contributor

Addresses part of #10350 Take advantage of C++17 feature structured bindings

There are few usages where std::tie is used on existing variables and for ordered operator== comparisons. These usages are not replaced.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 25, 2022
@karthikeyann karthikeyann self-assigned this Apr 25, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner April 25, 2022 17:35
@karthikeyann
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #10726 (ab372df) into branch-22.06 (d6e3068) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head ab372df differs from pull request most recent head ab6a81d. Consider uploading reports for the commit ab6a81d to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10726      +/-   ##
================================================
+ Coverage         86.36%   86.39%   +0.03%     
================================================
  Files               142      142              
  Lines             22302    22304       +2     
================================================
+ Hits              19261    19270       +9     
+ Misses             3041     3034       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/series.py 95.16% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.68% <0.00%> (+0.23%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae7e979...ab6a81d. Read the comment docs.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc1435b into rapidsai:branch-22.06 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants