Deprecate merge_sorted, change dask cudf usage to internal method

[isVoid]

This PR deprecates non-pandas conform method cudf.merge_sorted and change dask cudf usage to internal method _merge_sorted.

I also updated msg keyword in pytest.skip in multiple tests to reason, this removes 1000+ test warnings.

cc @vyasr @rjzamora

[codecov]

Codecov Report

Merging #10713 (1844f74) into branch-22.06 (d6e3068) will increase coverage by 0.07%.
The diff coverage is 93.33%.

❗ Current head 1844f74 differs from pull request most recent head 8558542. Consider uploading reports for the commit 8558542 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10713      +/-   ##
================================================
+ Coverage         86.36%   86.43%   +0.07%     
================================================
  Files               142      143       +1     
  Lines             22302    22448     +146     
================================================
+ Hits              19261    19403     +142     
- Misses             3041     3045       +4     

Impacted Files	Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py	0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/utils.py	0.00% <ø> (ø)
python/cudf/cudf/_lib/__init__.py	100.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py	79.76% <ø> (ø)
python/cudf/cudf/core/column/string.py	89.21% <ø> (+0.12%)	⬆️
python/cudf/cudf/testing/dataset_generator.py	73.25% <ø> (ø)
python/cudf/cudf/testing/testing.py	81.69% <ø> (ø)
python/custreamz/custreamz/kafka.py	29.16% <ø> (ø)
python/dask_cudf/dask_cudf/io/orc.py	91.04% <ø> (ø)
python/dask_cudf/dask_cudf/io/parquet.py	92.39% <81.08%> (-1.40%)	⬇️
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e3068...8558542. Read the comment docs.

[rjzamora]

Thanks @isVoid ! Moving merge_sorted to a private funciton makes sense to me.

Can we update the merge_sorted tests in test_reshape.py to point to the correct _merge_sorted function now (and maybe wrap the deprecated usage in a with pytest.warns block in one place)?

[vyasr]

Thanks @isVoid ! Moving merge_sorted to a private funciton makes sense to me.

Can we update the merge_sorted tests in test_reshape.py to point to the correct _merge_sorted function now (and maybe wrap the deprecated usage in a with pytest.warns block in one place)?

Yes, let's update the tests here if possible. That will make @bdice's job of removing warnings from tests easier. I'll admit that given the large number of warnings our tests currently throw I have been lax about making these changes in my own deprecation PRs, but in those cases the tests were getting entirely removed in the next release so there was less value in putting in the effort. In this case we expect to continue maintaining (and therefore testing) _merge_sorted indefinitely.

[isVoid]

rerun tests

[vyasr]

@rjzamora let us know if this looks good to you now.

[vyasr]

Ack sorry pushed the wrong button sorry. Did not mean to close.

[isVoid]

I also updated msg keyword in pytest.skip in multiple tests to reason, this removes 1000+ test warnings.

[rjzamora]

LGTM! Thanks @isVoid !

[vyasr]

I also updated msg keyword in pytest.skip in multiple tests to reason, this removes 1000+ test warnings.

@bdice will thank you.

[vyasr]

@gpucibot merge