Prepare dask_cudf test_parquet.py for upcoming API changes #10709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request rapidsai#5690 from ajschmidt8/phase2 [skip ci] Update master references for main branch
[RELEASE] Re-release v0.15 cudf [skip-ci]
[RELEASE] cudf v0.17
[RELEASE] cudf v0.18
[RELEASE] Release v0.18.1 cudf
[RELEASE] v0.18.2 `cudf` release [skip-ci]
[RELEASE] v0.19.1 cudf
[RELEASE] v0.19.2 cudf [skip-ci]
|
LGTM . I'll also ping @randerzander directly to get his comments on the changes |
quasiben
approved these changes
Apr 26, 2022
rjzamora
added
5 - Ready to Merge
randerzander
requested changes
Apr 26, 2022
galipremsagar
requested changes
Apr 26, 2022
Oops - Thanks for pointing this out @galipremsagar ! |
rjzamora
added
3 - Ready for Review
galipremsagar
approved these changes
Apr 27, 2022
|
@randerzander - It looks like this PR is now blocking cudf CI (the upstream changes have begun). So, let me know if the current changes are "ok" for now. |
randerzander
approved these changes
Apr 28, 2022
rjzamora
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively-simple PR to clean up
dask_cudf'sto/read_parquettests. These changes are mostly meant to avoid future test failures that will arise after impending changes are implemented in up-stream Dask. These changes include:write_metadata_filewill becomeFalseforto_parquet(because writing the _metadata file scales very poorly)split_row_groupswill becomeFalse(because this setting is typically optimal when the file are not too large). Users with larger-than-memory files will need to specifysplit_row_groups=True/intexplicitly.gather_statisticsargument will be removed in favor of a more descriptivecalculate_divisionsargument.This PR also removes the long-deprecated
row_groups_per_partargument fromdask_cudf.read_parquet(established replacement issplit_row_groups).