Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or simplify various utility functions #10705

Merged
merged 9 commits into from
Apr 21, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 21, 2022

This PR excises some of the functions in cudf/utils/utils.py and moves others as close to their point of use as possible. Most of the moved functions were essentially single-use functions, while the removed functions were either unnecessary or had obvious preexisting replacements.

@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 21, 2022
@vyasr vyasr added this to the CuDF Python Refactoring milestone Apr 21, 2022
@vyasr vyasr requested a review from a team as a code owner April 21, 2022 16:58
@vyasr vyasr self-assigned this Apr 21, 2022
@vyasr vyasr requested review from galipremsagar and isVoid April 21, 2022 16:58
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #10705 (32507a6) into branch-22.06 (65b1cbd) will increase coverage by 0.03%.
The diff coverage is 96.77%.

@@               Coverage Diff                @@
##           branch-22.06   #10705      +/-   ##
================================================
+ Coverage         86.35%   86.38%   +0.03%     
================================================
  Files               142      142              
  Lines             22335    22296      -39     
================================================
- Hits              19287    19261      -26     
+ Misses             3048     3035      -13     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.35% <ø> (+0.06%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.88% <50.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.97% <100.00%> (+0.20%) ⬆️
python/cudf/cudf/core/column/column.py 89.43% <100.00%> (-0.02%) ⬇️
python/cudf/cudf/core/column/string.py 89.21% <100.00%> (+0.10%) ⬆️
python/cudf/cudf/core/dataframe.py 93.75% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/multiindex.py 92.28% <100.00%> (+0.13%) ⬆️
python/cudf/cudf/core/series.py 95.15% <100.00%> (ø)
python/cudf/cudf/testing/_utils.py 93.98% <100.00%> (+0.13%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b1cbd...32507a6. Read the comment docs.

@vyasr
Copy link
Contributor Author

vyasr commented Apr 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5053a1a into rapidsai:branch-22.06 Apr 21, 2022
@vyasr vyasr deleted the refactor/utils branch January 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants