-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or simplify various utility functions #10705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
Ready for review by team
code quality
Python
Affects Python cuDF API.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Apr 21, 2022
shwina
approved these changes
Apr 21, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10705 +/- ##
================================================
+ Coverage 86.35% 86.38% +0.03%
================================================
Files 142 142
Lines 22335 22296 -39
================================================
- Hits 19287 19261 -26
+ Misses 3048 3035 -13
Continue to review full report at Codecov.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excises some of the functions in
cudf/utils/utils.py
and moves others as close to their point of use as possible. Most of the moved functions were essentially single-use functions, while the removed functions were either unnecessary or had obvious preexisting replacements.