Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct build dir cudf-config dependency issues for static builds #10704

Conversation

robertmaynard
Copy link
Contributor

When cudf is built statically we had the following three issues that
could cause consumers to fail to find cudf:

  1. kvikio was not setup to be exported properly
  2. Removed cuFile dependency when it isn't found
  3. Hint where to find nvcomp when built by cudf

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 21, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner April 21, 2022 16:01
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #10704 (c4eb041) into branch-22.06 (d6e3068) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head c4eb041 differs from pull request most recent head 27c2c63. Consider uploading reports for the commit 27c2c63 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10704      +/-   ##
================================================
+ Coverage         86.36%   86.39%   +0.03%     
================================================
  Files               142      142              
  Lines             22302    22302              
================================================
+ Hits              19261    19268       +7     
+ Misses             3041     3034       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.68% <0.00%> (+0.23%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399c910...27c2c63. Read the comment docs.

@jlowe jlowe linked an issue Apr 21, 2022 that may be closed by this pull request
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fixes the cudf Java build and spark-rapids-jni builds.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard robertmaynard force-pushed the correct_static_build_cudf-dependencies branch from f74fbf3 to 27c2c63 Compare April 25, 2022 15:24
@vyasr
Copy link
Contributor

vyasr commented Apr 25, 2022

rerun tests

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@vyasr
Copy link
Contributor

vyasr commented Apr 25, 2022

rerun tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudfjni build failed due to missing kvikio
4 participants