Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython API refactor: merge.pyx #10698

Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 20, 2022

This PR refactors merge_sorted in merge.pyx to accept a list of columns, contributes to #10153

@isVoid isVoid requested a review from a team as a code owner April 20, 2022 22:33
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #10698 (d8a61fc) into branch-22.06 (65b1cbd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10698      +/-   ##
================================================
+ Coverage         86.35%   86.39%   +0.04%     
================================================
  Files               142      142              
  Lines             22335    22302      -33     
================================================
- Hits              19287    19268      -19     
+ Misses             3048     3034      -14     
Impacted Files Coverage Δ
python/cudf/cudf/core/reshape.py 90.00% <100.00%> (+0.17%) ⬆️
python/cudf/cudf/core/column/column.py 89.43% <0.00%> (-0.02%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <0.00%> (ø)
python/cudf/cudf/core/series.py 95.15% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.75% <0.00%> (+<0.01%) ⬆️
python/cudf/cudf/utils/utils.py 90.35% <0.00%> (+0.06%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.10%) ⬆️
python/cudf/cudf/testing/_utils.py 93.98% <0.00%> (+0.13%) ⬆️
python/cudf/cudf/core/multiindex.py 92.28% <0.00%> (+0.13%) ⬆️
python/cudf/cudf/core/column/categorical.py 89.97% <0.00%> (+0.20%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6b70a...d8a61fc. Read the comment docs.

@isVoid isVoid changed the title Cython API refacotr: merge.pyx Cython API refactor: merge.pyx Apr 21, 2022
@isVoid isVoid self-assigned this Apr 21, 2022
@isVoid isVoid added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 21, 2022
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit

@isVoid
Copy link
Contributor Author

isVoid commented Apr 21, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Apr 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d6e3068 into rapidsai:branch-22.06 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants