Fix sphinx/jupyter heading issue in UDF notebook #10690
Conversation
brandon-b-miller
added
3 - Ready for Review
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@gpucibot merge |
| "Overview of User Defined Functions with cuDF\n", | ||
| "====================================" |
There was a problem hiding this comment.
I think the heading and the line below need to be of equal length, or else Sphinx throws warnings. Can you fix these and/or verify that no warnings are thrown?
| "Overview of User Defined Functions with cuDF\n", | |
| "====================================" | |
| "Overview of User Defined Functions with cuDF\n", | |
| "============================================" |
There was a problem hiding this comment.
(I might be a little late commenting after Ashwin directed this PR to merge.)
There was a problem hiding this comment.
Some of this is going to be fixed in #10685 anyway.
There was a problem hiding this comment.
I'm not getting warnings locally. I think it's because matching the character lengths is just a minimum, but I'm checking to make sure.
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10690 +/- ##
================================================
+ Coverage 86.35% 86.38% +0.03%
================================================
Files 142 142
Lines 22335 22335
================================================
+ Hits 19287 19294 +7
+ Misses 3048 3041 -7
Continue to review full report at Codecov.
|
Fixes an issue where sphinx was reading the
#'s in the UDF guide markdown cells as section headings causing strange effects in the docs main index page.