Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes a few imports across the cudf code base. Changes include:
import numpy as np
is common, butimport pyorc as po
andimport fastavro as fa
are non-standard and not the style used by their documentation. I leftimport cupy as cp
, since bothimport cupy
andimport cupy as cp
are prevalent in the code base (the one exception that I changed was a file that had bothimport cupy
andimport cupy as cp
).from some_package import x as x
-- just writefrom some_package import x
cimport
simport datetime
instead ofimport datetime as dt
to avoid conflicts with the many otherdt
names in our code (including local names that had the potential to shadow/overwrite the library's name)warnings.warn
rather thanfrom warnings import warn
for consistency across the library