Standardize usage of collections.abc. #10679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
code quality
Python
bdice
commented
Apr 18, 2022
| @@ -279,7 +279,7 @@ cdef csv_reader_options make_csv_reader_options( | |||
| ) | |||
| csv_reader_options_c.set_dtypes(c_dtypes_list) | |||
| csv_reader_options_c.set_parse_hex(c_hex_col_indexes) | |||
| elif isinstance(dtype, abc.Iterable): | |||
| elif isinstance(dtype, abc.Collection): | |||
There was a problem hiding this comment.
We must use Collection because an Iterable is not guaranteed to support len(dtype) below. Similarly in json.pyx.
bdice
commented
Apr 18, 2022
python/cudf/cudf/core/dataframe.py
Outdated
Comment on lines
3004
to
3007
| if isinstance(val, abc.Iterable): | ||
| idxs.update(val) | ||
| elif isinstance(val, str): | ||
| idxs.add(val) |
There was a problem hiding this comment.
The order of these statements may be a bug. Strings meet the requirements of Iterable, so the string code path may never be taken here. Strings should probably be handled first. I fixed this in 816319d.
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10679 +/- ##
================================================
+ Coverage 86.38% 86.41% +0.02%
================================================
Files 142 142
Lines 22334 22333 -1
================================================
+ Hits 19294 19299 +5
+ Misses 3040 3034 -6
Continue to review full report at Codecov.
|
Co-authored-by: GALI PREM SAGAR <[email protected]>
galipremsagar
approved these changes
Apr 18, 2022
galipremsagar
added
the
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase currently uses multiple ways of importing
collections.abcclasses in cudf. This can be problematic because the names incollections.abccan overlap with names intyping, so we need a way to disambiguate the two. This PR standardizes our imports such that abstract base classes follow a pattern so thatabc.is always in the name of abstract base classes.