Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix some docs build warnings #10674

Merged
merged 9 commits into from
May 17, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Apr 15, 2022

This PR fixes some docstrings and add's references to numpy.dtype at some places.

@galipremsagar galipremsagar self-assigned this Apr 15, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #10674 (7ed338b) into branch-22.06 (6352b4e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 7ed338b differs from pull request most recent head 58a77d8. Consider uploading reports for the commit 58a77d8 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10674      +/-   ##
================================================
+ Coverage         86.29%   86.33%   +0.03%     
================================================
  Files               144      144              
  Lines             22656    22665       +9     
================================================
+ Hits              19552    19567      +15     
+ Misses             3104     3098       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 85.71% <ø> (ø)
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.79% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/index.py 92.06% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/core/series.py 95.17% <ø> (ø)
python/cudf/cudf/core/column/string.py 88.78% <100.00%> (+0.12%) ⬆️
python/dask_cudf/dask_cudf/groupby.py 97.42% <100.00%> (+<0.01%) ⬆️
python/dask_cudf/dask_cudf/tests/test_groupby.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6352b4e...58a77d8. Read the comment docs.

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@galipremsagar galipremsagar changed the title [WIP] Doc fixes [REVIEW] Fix some docs build warnings May 17, 2022
@galipremsagar galipremsagar marked this pull request as ready for review May 17, 2022 14:07
@galipremsagar galipremsagar requested a review from a team as a code owner May 17, 2022 14:07
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change and removed inactive-30d labels May 17, 2022
@galipremsagar galipremsagar requested a review from bdice May 17, 2022 14:08
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, otherwise LGTM.

docs/cudf/source/conf.py Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 17, 2022
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, that fix for GenericIndex probably reduces a lot of warnings! Nice job.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1dbd3ca into rapidsai:branch-22.06 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants