Add device_memory_resource parameter to create_string_vector_from_column #10673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10673 +/- ##
================================================
+ Coverage 86.38% 86.41% +0.02%
================================================
Files 142 142
Lines 22334 22334
================================================
+ Hits 19294 19300 +6
+ Misses 3040 3034 -6
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
ttnghia
approved these changes
Apr 18, 2022
bdice
approved these changes
Apr 18, 2022
|
@gpucibot merge |
abellina
added a commit
to abellina/cudf
that referenced
this pull request
Apr 20, 2022
…from_column (rapidsai#10673)" This reverts commit 08cd428.
This was referenced Apr 20, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
Closes #10717 Fixes bug introduced with changes in #10673 which uses the `cudf::make_strings_column` that accepts a span of `string_view` objects with a null-placeholder. The placeholder can be unintentionally created in `create_string_vector_from_column` when given a strings column where all the rows are empty. The utility is fixed to prevent creating the placeholder for empty strings. A gtest was added to scatter from/to an all-empty strings column to verify this behavior. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard) URL: #10724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
rmm::mr::device_memory_resourceparameter to thecudf::strings::detail::create_string_vector_from_columnfunction. This will be called in a future API in a later PR and the resulting memory object will returned to the user.Also found and removed a few related functions that are no longer necessary and updated the callers appropriately simplifying the logic there.