-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical operator style fix in reduce.cuh
#10670
Logical operator style fix in reduce.cuh
#10670
Conversation
I don't have any qualms with mixing |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10670 +/- ##
================================================
+ Coverage 86.33% 86.37% +0.03%
================================================
Files 140 142 +2
Lines 22289 22356 +67
================================================
+ Hits 19244 19309 +65
- Misses 3045 3047 +2
Continue to review full report at Codecov.
|
I feel similarly to @jrhemstad on this — I would rather change |
That's ok with me. It irritates me a little bit when I see inconsistencies in the same file with |
Addressing #10447 (comment), logical operators should be consistent in a statement.