Enable segmented_gather in Java package #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10669 +/- ##
================================================
+ Coverage 86.34% 86.41% +0.06%
================================================
Files 142 142
Lines 22356 22334 -22
================================================
- Hits 19304 19300 -4
+ Misses 3052 3034 -18
Continue to review full report at Codecov.
|
revans2
requested changes
Apr 15, 2022
| try { | ||
| cudf::jni::auto_set_device(env); | ||
| auto src_col = reinterpret_cast<cudf::lists_column_view *>(source_column); | ||
| auto gather_map = reinterpret_cast<cudf::lists_column_view *>(gather_map_list); |
There was a problem hiding this comment.
Please cast these to a cudf::column_view and then create a cudf::lists_column_view from them. Otherwise there is no checking that the columns passed in are really lists. If they are not really bad things could happen.
revans2
approved these changes
Apr 18, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR is to enable cuDF API
segmented_gatherin Java package.segmented_gatheris essential to implement spark array functions likearrays_zip(NVIDIA/spark-rapids#5229).