Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::filesystem for temporary directory location and deletion #10664

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Apr 14, 2022

Addressing a long-standing TODO. Since std::filesystem is available since C++17, use it to recursively delete temporary directories (used for benchmarks, etc.).
Small step towards portable temp directory/file utilities.

@vuule vuule added tests Unit testing for project improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 14, 2022
@vuule vuule self-assigned this Apr 14, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #10664 (c3b82b5) into branch-22.06 (03e84ef) will increase coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10664      +/-   ##
================================================
+ Coverage         86.34%   86.37%   +0.03%     
================================================
  Files               142      142              
  Lines             22352    22356       +4     
================================================
+ Hits              19299    19310      +11     
+ Misses             3053     3046       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.75% <0.00%> (+0.06%) ⬆️
python/cudf/cudf/core/column/string.py 89.10% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.79% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e84ef...c3b82b5. Read the comment docs.

@vuule vuule marked this pull request as ready for review April 14, 2022 22:58
@vuule vuule requested a review from a team as a code owner April 14, 2022 22:58
@vuule
Copy link
Contributor Author

vuule commented Apr 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9e1258d into rapidsai:branch-22.06 Apr 15, 2022
@vuule vuule deleted the tmp_dir_use_filesystem branch April 15, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants