Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup benchmark includes #10661

Merged
merged 4 commits into from
Apr 19, 2022
Merged

cleanup benchmark includes #10661

merged 4 commits into from
Apr 19, 2022

Conversation

karthikeyann
Copy link
Contributor

  • remove cudf_test unnecessary includes
  • fix include order
  • remove benchmark/benchmark.h when benchmark fixture is included

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team tests Unit testing for project code quality 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 14, 2022
@karthikeyann karthikeyann self-assigned this Apr 14, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner April 14, 2022 18:29
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 14, 2022
@karthikeyann karthikeyann changed the title remove cudf_test unnecessary includes cleanup benchmark includes Apr 14, 2022
@karthikeyann karthikeyann mentioned this pull request Apr 14, 2022
Merged
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #10661 (bc50abc) into branch-22.06 (94a5d41) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10661      +/-   ##
================================================
+ Coverage         86.38%   86.41%   +0.02%     
================================================
  Files               142      142              
  Lines             22334    22334              
================================================
+ Hits              19294    19300       +6     
+ Misses             3040     3034       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 89.22% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.79% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a5d41...bc50abc. Read the comment docs.

bdice
bdice approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Please make sure everything compiles locally, since CI does not compile the benchmarks and would not catch any failures.

@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ba1173d into rapidsai:branch-22.06 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@PointKernel PointKernel Awaiting requested review from PointKernel PointKernel is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @bdice @ttnghia