Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementation details from apply docstrings #10651

Conversation

brandon-b-miller
Copy link
Contributor

Removes some unnecessary implementation detail from apply docstrings and updates them where necessary.

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner April 13, 2022 18:00
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 13, 2022
@galipremsagar galipremsagar added non-breaking Non-breaking change doc Documentation improvement Improvement / enhancement to an existing function labels Apr 13, 2022
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 13, 2022
@galipremsagar galipremsagar removed the improvement Improvement / enhancement to an existing function label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #10651 (57d5e82) into branch-22.06 (3c13ef1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10651      +/-   ##
================================================
+ Coverage         86.33%   86.37%   +0.03%     
================================================
  Files               140      140              
  Lines             22289    22304      +15     
================================================
+ Hits              19244    19265      +21     
+ Misses             3045     3039       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.72% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.28% <ø> (ø)
python/cudf/cudf/core/single_column_frame.py 96.52% <ø> (+0.07%) ⬆️
python/cudf/cudf/utils/cudautils.py 59.83% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/column/lists.py 92.79% <100.00%> (+1.38%) ⬆️
python/cudf/cudf/core/dataframe.py 93.65% <100.00%> (+0.06%) ⬆️
python/cudf/cudf/utils/ioutils.py 79.60% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8e92c...57d5e82. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Apr 13, 2022

Thanks, @brandon-b-miller!

@gpucibot merge

@shwina
Copy link
Contributor

shwina commented Apr 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c72868e into rapidsai:branch-22.06 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants