Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda to build python packages during GPU tests #10648

Merged
merged 1 commit into from
May 9, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Apr 13, 2022

This PR convert the from sources build we are doing in GPU test job to a conda build. This is done for the following reasons:

  • This is required step to improve the Ops CI/CD setup to a more convenient pipeline
  • This is required to start using conda compilers and mamba to build RAPIDS packages
  • This prevent us from manually managing and installing the dependencies in GPU job
  • This ensure the packages can be installed
  • This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested.

This may increase the global pipeline time, but the usage of mamba should resolve this as mamba is faster than conda to build packages

@jjacobelli jjacobelli added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 13, 2022
@jjacobelli jjacobelli requested a review from a team as a code owner April 13, 2022 11:35
@jjacobelli jjacobelli self-assigned this Apr 13, 2022
@github-actions github-actions bot added the gpuCI label Apr 13, 2022
@jjacobelli jjacobelli force-pushed the remove-from-sources branch from 38e8c84 to 412063d Compare April 13, 2022 12:22
@jjacobelli jjacobelli marked this pull request as draft April 13, 2022 12:46
@jjacobelli jjacobelli force-pushed the remove-from-sources branch 4 times, most recently from fbe516d to 1271f0b Compare April 14, 2022 08:08
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #10648 (d6be3c5) into branch-22.06 (3c13ef1) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head d6be3c5 differs from pull request most recent head 565b27d. Consider uploading reports for the commit 565b27d to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10648      +/-   ##
================================================
- Coverage         86.33%   86.29%   -0.05%     
================================================
  Files               140      143       +3     
  Lines             22289    22493     +204     
================================================
+ Hits              19244    19410     +166     
- Misses             3045     3083      +38     
Impacted Files Coverage Δ
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <0.00%> (-67.93%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 50.00% <0.00%> (-4.29%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 92.39% <0.00%> (-1.40%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <0.00%> (-1.34%) ⬇️
python/dask_cudf/dask_cudf/tests/test_binops.py 92.00% <0.00%> (-0.60%) ⬇️
python/cudf/cudf/api/types.py 89.36% <0.00%> (-0.44%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.36% <0.00%> (-0.27%) ⬇️
python/cudf/cudf/comm/gpuarrow.py 79.76% <0.00%> (-0.24%) ⬇️
python/cudf/cudf/core/series.py 95.16% <0.00%> (-0.12%) ⬇️
python/cudf/cudf/core/indexed_frame.py 91.70% <0.00%> (-0.07%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea6f8e...565b27d. Read the comment docs.

@jjacobelli jjacobelli force-pushed the remove-from-sources branch from 1271f0b to b2716fe Compare April 25, 2022 09:28
@jjacobelli jjacobelli removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 25, 2022
@jjacobelli jjacobelli marked this pull request as ready for review April 25, 2022 09:38
@jjacobelli jjacobelli force-pushed the remove-from-sources branch from b2716fe to 565b27d Compare May 9, 2022 12:51
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0fdb6dc into rapidsai:branch-22.06 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants