Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate various functions that don't need to be defined for Index. #10647

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 13, 2022

This PR adds deprecations for various Frame methods that shouldn't actually be defined for Index objects. These methods can all be moved down to IndexedFrame in 22.08. This change contributes to making a clean distinction between Frame and IndexedFrame.

@vyasr vyasr added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 13, 2022
@vyasr vyasr added this to the CuDF Python Refactoring milestone Apr 13, 2022
@vyasr vyasr requested a review from a team as a code owner April 13, 2022 00:39
@vyasr vyasr self-assigned this Apr 13, 2022
@vyasr vyasr requested review from bdice and isVoid April 13, 2022 00:39
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions/comments. Otherwise LGTM. This will help with the errors in Sphinx docs!

python/cudf/cudf/core/frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/frame.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #10647 (c54dcde) into branch-22.06 (3c13ef1) will increase coverage by 0.02%.
The diff coverage is 83.60%.

@@               Coverage Diff                @@
##           branch-22.06   #10647      +/-   ##
================================================
+ Coverage         86.33%   86.36%   +0.02%     
================================================
  Files               140      142       +2     
  Lines             22289    22352      +63     
================================================
+ Hits              19244    19305      +61     
- Misses             3045     3047       +2     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.72% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.28% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 59.83% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/frame.py 93.67% <56.52%> (-1.09%) ⬇️
python/cudf/cudf/core/column/lists.py 92.79% <100.00%> (+1.38%) ⬆️
python/cudf/cudf/core/dataframe.py 93.69% <100.00%> (+0.10%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7143a...c54dcde. Read the comment docs.

@vyasr
Copy link
Contributor Author

vyasr commented Apr 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 489e41f into rapidsai:branch-22.06 Apr 13, 2022
@vyasr vyasr deleted the deprecation/frame_index_methods branch October 22, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants