Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinning to allow newer CMake versions. #10646

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 12, 2022

CMake 3.23.1 contains the bug fixes that we need to make use of CMake 3.23, so now we can update the pinnings to just avoid 3.23.0.

@vyasr vyasr added 3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 12, 2022
@vyasr vyasr self-assigned this Apr 12, 2022
@vyasr vyasr requested a review from a team as a code owner April 12, 2022 23:58
@github-actions github-actions bot added conda and removed CMake CMake build issue labels Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #10646 (a704962) into branch-22.06 (3c13ef1) will increase coverage by 0.03%.
The diff coverage is 92.15%.

@@               Coverage Diff                @@
##           branch-22.06   #10646      +/-   ##
================================================
+ Coverage         86.33%   86.37%   +0.03%     
================================================
  Files               140      140              
  Lines             22289    22304      +15     
================================================
+ Hits              19244    19265      +21     
+ Misses             3045     3039       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.72% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.28% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 59.83% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/frame.py 94.30% <50.00%> (-0.45%) ⬇️
python/cudf/cudf/core/column/lists.py 92.79% <100.00%> (+1.38%) ⬆️
python/cudf/cudf/core/dataframe.py 93.65% <100.00%> (+0.06%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e16c7...a704962. Read the comment docs.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 03e84ef into rapidsai:branch-22.06 Apr 14, 2022
@vyasr vyasr deleted the update_cmake_pinning branch January 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants