Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cudf.read_json as documented API name. #10640

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 12, 2022

Changes documented API name from cudf.io.json.read_json to cudf.read_json. This aligns with Pandas' documentation and eliminates an awkward switch of the .. currentmodule in Sphinx. See thread: #10638 (comment)

@bdice bdice added doc Documentation non-breaking Non-breaking change labels Apr 12, 2022
@bdice bdice requested a review from a team as a code owner April 12, 2022 00:37
@bdice bdice self-assigned this Apr 12, 2022
@bdice bdice requested review from shwina, brandon-b-miller and vuule and removed request for shwina and brandon-b-miller April 12, 2022 00:37
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 12, 2022
@bdice bdice requested a review from galipremsagar April 12, 2022 00:37
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #10640 (8dd4e67) into branch-22.06 (bf4ffc9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10640      +/-   ##
================================================
+ Coverage         86.33%   86.36%   +0.02%     
================================================
  Files               140      140              
  Lines             22289    22289              
================================================
+ Hits              19244    19250       +6     
+ Misses             3045     3039       -6     
Impacted Files Coverage Δ
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/dask_cudf/dask_cudf/backends.py 86.44% <100.00%> (ø)
python/dask_cudf/dask_cudf/sorting.py 93.03% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 89.10% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.70% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b080d...8dd4e67. Read the comment docs.

Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdice
Copy link
Contributor Author

bdice commented Apr 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d6c15e4 into rapidsai:branch-22.06 Apr 12, 2022
@bdice bdice deleted the doc/read-json branch April 19, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants