-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for numeric_only in DataFrame._reduce #10629
Add support for numeric_only in DataFrame._reduce #10629
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
ok to test |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10629 +/- ##
================================================
+ Coverage 86.31% 86.37% +0.05%
================================================
Files 140 142 +2
Lines 22280 22356 +76
================================================
+ Hits 19232 19309 +77
+ Misses 3048 3047 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! I have a few small requests, then this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM!
@gpucibot merge |
Add support for numeric_only in DataFrame._reduce, this way can use df.mean(numeric_only=True), etc. Resolves #2067. Also partially addresses #9009.