Fix type-o in docstring for json_reader_options #10626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
cwharris
approved these changes
Apr 8, 2022
cwharris
added
doc
|
@dagardner-nv Thanks! base branch needs to be updated to 22.06 for CI to run. |
PointKernel
requested changes
Apr 8, 2022
Co-authored-by: Yunsong Wang <[email protected]>
|
Closing will cherry-pick commits into branch-22.06 and open a new pull req |
|
New pull req #10627 |
ajschmidt8
pushed a commit
that referenced
this pull request
Apr 8, 2022
Same as #10626 but against the correct branch Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Christopher Harris (https://github.com/cwharris) - Yunsong Wang (https://github.com/PointKernel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found a typo in the docstring
"Not all parameters are unsupported."
should be:
"Not all parameters are supported."