-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for null and non-numeric types in Series.diff and DataFrame.diff #10625
Add support for null and non-numeric types in Series.diff and DataFrame.diff #10625
Conversation
Can one of the admins verify this patch? |
add to allowlist (edit: looks like this didn't work. I may not have privileges to add Matt to the list of allowed CI users.) |
add to allowlist |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10625 +/- ##
================================================
+ Coverage 86.34% 86.41% +0.06%
================================================
Files 142 142
Lines 22356 22334 -22
================================================
- Hits 19304 19299 -5
+ Misses 3052 3035 -17
Continue to review full report at Codecov.
|
By ripping out the diff numba kernel and using shift + binary op, I believe this will provide null support. Perhaps worth reflecting including in the PR title for the changelog? |
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
…feature/diff-non-numeric
…/cudf into feature/diff-non-numeric
…feature/diff-non-numeric
@gpucibot merge |
1 similar comment
@gpucibot merge |
This PR supports non-numeric data types (timestamp and ranges) in
Series.diff
andDataFrame.diff
. InDataFrame.diff
, datetime ranges are already supported becauseDataFrame.shift
works. ButSeries.diff
doesn't use theSeries.shift
implementation, so there wasn't support for datetime ranges.closes #10212.