Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow libcudfjni to be built as a static library #10619

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Apr 7, 2022

This adds the ability for the JNI native libraries to be built as static libraries rather than shared libraries by specifying -DBUILD_SHARED_LIBS=OFF when configuring with cmake. This can be useful for external projects that are leveraging the JNI libraries and would like to use an archive that they can link into their shared library.

@jlowe jlowe added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2022
@jlowe jlowe self-assigned this Apr 7, 2022
@jlowe jlowe requested a review from a team as a code owner April 7, 2022 21:01
@github-actions github-actions bot added the CMake CMake build issue label Apr 7, 2022
java/pom.xml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #10619 (8fc5ec2) into branch-22.06 (956c7b5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10619      +/-   ##
================================================
+ Coverage         86.30%   86.34%   +0.03%     
================================================
  Files               140      140              
  Lines             22255    22280      +25     
================================================
+ Hits              19207    19237      +30     
+ Misses             3048     3043       -5     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/tests/test_accessor.py 98.41% <ø> (ø)
python/cudf/cudf/core/column/lists.py 90.62% <100.00%> (+0.57%) ⬆️
python/cudf/cudf/core/indexed_frame.py 91.77% <0.00%> (-0.87%) ⬇️
python/cudf/cudf/core/series.py 95.28% <0.00%> (-0.01%) ⬇️
python/cudf/cudf/core/column/column.py 89.45% <0.00%> (+0.10%) ⬆️
python/cudf/cudf/core/column/string.py 89.10% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/frame.py 94.75% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261879f...8fc5ec2. Read the comment docs.

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlowe
Copy link
Member Author

jlowe commented Apr 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 26c1810 into rapidsai:branch-22.06 Apr 7, 2022
@jlowe jlowe deleted the jni-static-lib branch April 7, 2022 22:37
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants