-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow libcudfjni to be built as a static library #10619
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10619 +/- ##
================================================
+ Coverage 86.30% 86.34% +0.03%
================================================
Files 140 140
Lines 22255 22280 +25
================================================
+ Hits 19207 19237 +30
+ Misses 3048 3043 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gpucibot merge |
This adds the ability for the JNI native libraries to be built as static libraries rather than shared libraries by specifying
-DBUILD_SHARED_LIBS=OFF
when configuring with cmake. This can be useful for external projects that are leveraging the JNI libraries and would like to use an archive that they can link into their shared library.